this post was submitted on 11 Oct 2023
361 points (97.9% liked)

Programming

18454 readers
63 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 2 years ago
MODERATORS
 

"UPDATE table_name SET w = $1, x = $2, z = $4 WHERE y = $3 RETURNING *",

does not do the same as

"UPDATE table_name SET w = $1, x = $2, y = $3, z = $4 RETURNING *",

It's 2 am and my mind blanked out the WHERE, and just wanted the numbers neatly in order of 1234.

idiot.

FML.

(page 2) 50 comments
sorted by: hot top controversial new old
[–] o11c@programming.dev 5 points 1 year ago

This is about the one thing where SQL is a badly designed language, and you should use a frontend that forces you to write your queries in the order (table, filter, columns) for consistency.

UPDATE table_name WHERE y = $3 SET w = $1, x = $2, z = $4 RETURNING *
FROM table_name SELECT w, x, y, z
[–] evatronic@lemm.ee 4 points 1 year ago (1 children)

Unrelated, but use placeholders instead of interpolation right into the query.

See: Little Bobby Tables. https://xkcd.com/327/

[–] sim642@lemm.ee 4 points 1 year ago (1 children)

That's what they're doing...

[–] evatronic@lemm.ee 1 points 1 year ago

If true, great. I've not run across a language / RDBMs library that uses numbered place holders over the standard ?, but I'm sure someone's done it.

[–] Techmaster@lemm.ee 4 points 1 year ago

If it's Microsoft SQL you should be able to replay the transaction log. But you should be doing something like daily full backups and hourly incremental or differential backups to avoid this situation in the first place.

[–] books@lemmy.world 4 points 1 year ago

Things like this make me glad I can only query my db.

[–] SeabassDan@lemmy.world 4 points 1 year ago

Ctrl+z bro

Jk, sounds tough

[–] gatelike@feddit.de 3 points 1 year ago

SQL scouts credo: I will never use indexes, I will always use column names.

[–] Wakmrow@lemmy.world 2 points 1 year ago

I learned this lesson too

[–] Tarte@kbin.social 2 points 1 year ago* (last edited 1 year ago)

I‘m using DataGrip (IntelliJ) for any manual SQL tomfoolery. I have been where you are. Luckily for me, the tool asks for additional confirmation when doing any update/delete without where clause.

Also, backups are a must, for all the right reasons and for any project.

[–] oldfart@lemm.ee 1 points 1 year ago

Been there, done that, I hope you have a recent backup!

[–] superfes@lemmy.world 1 points 1 year ago

I know it's too late to be helpful now, but I always write the WHERE first, because you are not the first person to have done this...

load more comments
view more: ‹ prev next ›