this post was submitted on 29 Mar 2024
964 points (98.3% liked)

Programmer Humor

21279 readers
688 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
964
Review Please (programming.dev)
submitted 11 months ago by JPDev@programming.dev to c/programmer_humor@programming.dev
87 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] magic_lobster_party@kbin.run 5 points 11 months ago

Stuffing multiple tasks into one PR is often bad.

  • It’s harder to review. As a reviewer it’s difficult to know which code change is related to which task.
  • It’s harder to verify. Did you really test every change you made?
  • You might end up with a “hostage” situation. There might be a few code changes in the PR that looks good and is really wanted, but other code changes in the same PR of lower quality. As a reviewer, should you just let these lower quality code changes slide so you can bring in the code change you really want? Probably not, but you’re going to let it slide either way.